raytracing/raytracer_challenge
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[FIX] Fix matrix view_transform

Browse Source
This commit is contained in:
NADAL Jean-Baptiste
2024-02-26 10:47:30 +01:00
parent a0f6a3f2f2
commit 93ea478cc9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
raytracing/src/matrix.cpp
View File

@@ -397,7 +397,7 @@ Matrix Matrix::shearing(double a_xy, double a_xz, double a_yx, double a_yz, doub
/* ------------------------------------------------------------------------- */ /* ------------------------------------------------------------------------- */
Matrix Matrix::view_transform(Tuple a_from, Tuple a_to, Tuple an_up) Matrix Matrix::view_transform(const Tuple &a_from, const Tuple &a_to, const Tuple &an_up)
{ {
Tuple the_forward = (a_to - a_from).normalize(); Tuple the_forward = (a_to - a_from).normalize();
Tuple the_up_normalized = an_up.normalize(); Tuple the_up_normalized = an_up.normalize();

2
raytracing/src/matrix.h
View File

@@ -77,7 +77,7 @@ namespace Raytracer
static Matrix rotation_y(double a_radians); static Matrix rotation_y(double a_radians);
static Matrix rotation_z(double a_radians); static Matrix rotation_z(double a_radians);
static Matrix shearing(double a_xy, double a_xz, double a_yx, double a_yz, double a_zx, double a_zy); static Matrix shearing(double a_xy, double a_xz, double a_yx, double a_yz, double a_zx, double a_zy);
static Matrix view_transform(Tuple a_from, Tuple a_to, Tuple an_up); static Matrix view_transform(const Tuple &a_from, const Tuple &a_to, const Tuple &an_up);
private: private:
bool validate_dimensions(const std::initializer_list<std::initializer_list<double>> &a_values) const; bool validate_dimensions(const std::initializer_list<std::initializer_list<double>> &a_values) const;